public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions
Date: Fri, 27 Feb 2026 14:54:14 +1000	[thread overview]
Message-ID: <review-patch1-20260224-drm-amdkfd-ttmp11-sched-mode-v1-1-4254ff8952c4@redhat.com> (raw)
In-Reply-To: <20260224-drm-amdkfd-ttmp11-sched-mode-v1-1-4254ff8952c4@redhat.com>

Patch Review

**Correctness:** The patch is correct. The three variables (`TTMP11_SCHED_MODE_SHIFT`, `TTMP11_SCHED_MODE_SIZE`, `TTMP11_SCHED_MODE_MASK`) had two identical definitions. All four usage sites (lines 241-243, 329-330, 1379) are within `#if RELAXED_SCHEDULING_IN_TRAP` guards, so wrapping the single remaining definition in the same guard is correct.

**Location choice:** The surviving definition at line 131-135 (post-patch) is well-placed alongside the other `TTMP11_*` field definitions (`TTMP11_DEBUG_TRAP_ENABLED_*`, `TTMP11_FIRST_REPLAY_*`, etc.) starting at line 136, which is a better grouping than the removed location near the `BARRIER_STATE_*` variables.

**Minor nit:** The `#endif` on line 135 is immediately followed by `var TTMP11_DEBUG_TRAP_ENABLED_SHIFT` on line 136 with no blank line separating them:

```asm
#if RELAXED_SCHEDULING_IN_TRAP
var TTMP11_SCHED_MODE_SHIFT			= 26
var TTMP11_SCHED_MODE_SIZE			= 2
var TTMP11_SCHED_MODE_MASK			= 0xC000000
#endif
var TTMP11_DEBUG_TRAP_ENABLED_SHIFT		= 23
```

This matches the style of the `#if HAVE_BANKED_VGPRS` block just above (lines 126-129), so it's consistent. No issue.

**Reviewed-by consideration:** This is a safe cleanup with no functional change. The Fixes tag referencing `bbcad5a8896b` is appropriate since that commit introduced the duplication.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-27  4:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 17:21 [PATCH] drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Peter Colberg
2026-02-27  4:54 ` Claude Code Review Bot [this message]
2026-02-27  4:54 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-03 21:29 [PATCH RESEND] " Peter Colberg
2026-03-03 22:32 ` Claude review: " Claude Code Review Bot
2026-03-03 22:32 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260224-drm-amdkfd-ttmp11-sched-mode-v1-1-4254ff8952c4@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox