From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Date: Fri, 27 Feb 2026 14:54:14 +1000 Message-ID: In-Reply-To: <20260224-drm-amdkfd-ttmp11-sched-mode-v1-1-4254ff8952c4@redhat.com> References: <20260224-drm-amdkfd-ttmp11-sched-mode-v1-1-4254ff8952c4@redhat.com> <20260224-drm-amdkfd-ttmp11-sched-mode-v1-1-4254ff8952c4@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness:** The patch is correct. The three variables (`TTMP11_SCHED_MODE_SHIFT`, `TTMP11_SCHED_MODE_SIZE`, `TTMP11_SCHED_MODE_MASK`) had two identical definitions. All four usage sites (lines 241-243, 329-330, 1379) are within `#if RELAXED_SCHEDULING_IN_TRAP` guards, so wrapping the single remaining definition in the same guard is correct. **Location choice:** The surviving definition at line 131-135 (post-patch) is well-placed alongside the other `TTMP11_*` field definitions (`TTMP11_DEBUG_TRAP_ENABLED_*`, `TTMP11_FIRST_REPLAY_*`, etc.) starting at line 136, which is a better grouping than the removed location near the `BARRIER_STATE_*` variables. **Minor nit:** The `#endif` on line 135 is immediately followed by `var TTMP11_DEBUG_TRAP_ENABLED_SHIFT` on line 136 with no blank line separating them: ```asm #if RELAXED_SCHEDULING_IN_TRAP var TTMP11_SCHED_MODE_SHIFT = 26 var TTMP11_SCHED_MODE_SIZE = 2 var TTMP11_SCHED_MODE_MASK = 0xC000000 #endif var TTMP11_DEBUG_TRAP_ENABLED_SHIFT = 23 ``` This matches the style of the `#if HAVE_BANKED_VGPRS` block just above (lines 126-129), so it's consistent. No issue. **Reviewed-by consideration:** This is a safe cleanup with no functional change. The Fixes tag referencing `bbcad5a8896b` is appropriate since that commit introduced the duplication. --- Generated by Claude Code Patch Reviewer