From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: Introduce drm_output_color_format enum Date: Fri, 27 Feb 2026 15:17:07 +1000 Message-ID: In-Reply-To: <20260224-drm-rework-color-formats-v1-1-bebc76604ada@kernel.org> References: <20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org> <20260224-drm-rework-color-formats-v1-1-bebc76604ada@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean introduction patch. The enum is well-documented and the `DRM_COLOR_FORMAT_*` defines are correctly redefined in terms of the new enum values: ```c #define DRM_COLOR_FORMAT_RGB444 (1 << DRM_OUTPUT_COLOR_FORMAT_RGB444) ``` This ensures backward compatibility during the transition. **Nit**: The `@color_formats` doc update says "Uses a bitmask of DRM_OUTPUT_COLOR_FORMAT\_" but these are enum values used with `BIT()`, not defines themselves. Consider: "Uses a bitmask of `BIT(enum drm_output_color_format)` values". **Nit**: The double blank line between the `*` and `* @DRM_OUTPUT_COLOR_FORMAT_RGB444:` in the kdoc is unusual (lines 303-304 in the diff). --- Generated by Claude Code Patch Reviewer