public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: ti: k3-j721e: Add GPU node
Date: Fri, 27 Feb 2026 14:48:58 +1000	[thread overview]
Message-ID: <review-patch1-20260224-gpu_dts-v1-1-cc5ddffe140c@ti.com> (raw)
In-Reply-To: <20260224-gpu_dts-v1-1-cc5ddffe140c@ti.com>

Patch Review

**Author:** Antonios Christidis

This adds the Series 8XE (GE8430) GPU node for the J721E SoC.

**Ordering issue:** This patch uses the `"ti,j721e-gpu"` compatible string, but the dt-binding adding this compatible doesn't come until patch 2. Per kernel convention, the binding documentation should come first so that `dt_binding_check` can validate the DTS. These two patches should be reordered.

**The DTS node itself looks reasonable:**

```dts
gpu: gpu@4e20000000 {
    compatible = "ti,j721e-gpu", "img,img-ge8430", "img,img-rogue";
    reg = <0x4e 0x20000000 0x00 0x80000>;
    clocks = <&k3_clks 125 0>;
    clock-names = "core";
    assigned-clocks = <&k3_clks 125 0>;
    assigned-clock-rates = <750000000>;
    interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
    power-domains = <&k3_pds 125 TI_SCI_PD_EXCLUSIVE>,
            <&k3_pds 126 TI_SCI_PD_EXCLUSIVE>;
    power-domain-names = "a", "b";
    dma-coherent;
};
```

- The compatible string triple (`ti,j721e-gpu`, `img,img-ge8430`, `img,img-rogue`) correctly follows the fallback chain pattern.
- `power-domain-names = "a", "b"` -- these names are very generic. Is this the established pattern for TI GPU power domains? If so, fine, but more descriptive names would be preferable.
- **Missing `status = "disabled"`**: Many TI DTS main dtsi files use `status = "disabled"` for peripheral nodes, with board-level dts files enabling them. Is the GPU always expected to be enabled? If not, this should be disabled by default.

**Commit message** is terse ("Add the series 8XE GPU node for j721e device tree.") but adequate for a DTS patch.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-27  4:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 18:09 [PATCH 0/5] drm/imagination: add support for j721e,j784s4,j722s,am62p Antonios Christidis
2026-02-24 18:09 ` [PATCH 1/5] arm64: dts: ti: k3-j721e: Add GPU node Antonios Christidis
2026-02-27  4:48   ` Claude Code Review Bot [this message]
2026-02-24 18:09 ` [PATCH 2/5] dt-bindings: gpu: img: Add J721e SoC specific compatible Antonios Christidis
2026-02-24 23:09   ` Andrew Davis
2026-02-25 11:06   ` Krzysztof Kozlowski
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 3/5] arm64: dts: ti: k3-j784s4: Add GPU node Antonios Christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 4/5] arm64: dts: ti: add " a-christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 5/5] clk: keystone: don't cache clock rate a-christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-25  1:05 ` [PATCH 0/5] drm/imagination: add support for j721e,j784s4,j722s,am62p Nishanth Menon
2026-02-27  4:48 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260224-gpu_dts-v1-1-cc5ddffe140c@ti.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox