public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: bridge: lt8713sx: Add bindings
Date: Fri, 27 Feb 2026 14:52:52 +1000	[thread overview]
Message-ID: <review-patch1-20260224-lt8713sx-bridge-driver-v4-1-b5603f5458d8@oss.qualcomm.com> (raw)
In-Reply-To: <20260224-lt8713sx-bridge-driver-v4-1-b5603f5458d8@oss.qualcomm.com>

Patch Review

**Missing `enable-gpios` property:** The driver calls `devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH)` but the binding does not document an `enable-gpios` property. If the hardware supports this GPIO, it must be documented in the binding. If it's not a real hardware signal, the driver shouldn't request it.

**Supplies not required:** The `vcc-supply` and `vdd-supply` properties are defined but not listed in `required:`. The driver calls `devm_regulator_get_enable()` for both unconditionally (not optional), so either the bindings should mark them as required, or the driver should handle them being absent. Typically regulators are required:

```yaml
+  vcc-supply:
+    description: Regulator for 3.3V vcc.
+
+  vdd-supply:
+    description: Regulator for 1.1V vdd.
```

These should be in the `required:` list if the driver mandates them.

**`reset-gpios` not required:** Similarly, `reset-gpios` is not in `required:` but the driver does `devm_gpiod_get()` (not `_optional`), meaning it will fail if absent. It should be required in the binding:

```yaml
+  reset-gpios:
+    description: GPIO connected to active low RESET pin.
```

**Port descriptions are vague:** Ports 1, 2, and 3 all say "DP port for DP output from bridge" or "Additional DP port for DP output from bridge". Given the chip supports DP, HDMI, and DP++, the descriptions should clarify what each output actually is, or if they're truly generic, say so explicitly.

**No `maxItems` on reset-gpios:** Standard practice is to add `maxItems: 1` to single GPIO properties.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-27  4:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 17:55 [PATCH v4 0/2] Add lontium lt8713sx bridge driver Vishnu Saini
2026-02-24 17:55 ` [PATCH v4 1/2] dt-bindings: bridge: lt8713sx: Add bindings Vishnu Saini
2026-02-25 10:35   ` Krzysztof Kozlowski
2026-02-25 14:12     ` Vishnu Saini
2026-02-27  4:52   ` Claude Code Review Bot [this message]
2026-02-24 17:55 ` [PATCH v4 2/2] drm/bridge: add support for lontium lt8713sx bridge driver Vishnu Saini
2026-02-27  4:52   ` Claude review: " Claude Code Review Bot
2026-02-27  4:52 ` Claude review: Add " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-03 16:43 [PATCH v5 0/2] " Vishnu Saini
2026-03-03 16:43 ` [PATCH v5 1/2] dt-bindings: bridge: lt8713sx: Add bindings Vishnu Saini
2026-03-03 20:57   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260224-lt8713sx-bridge-driver-v4-1-b5603f5458d8@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox