From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: bridge: lt8713sx: Add bindings Date: Fri, 27 Feb 2026 14:52:52 +1000 Message-ID: In-Reply-To: <20260224-lt8713sx-bridge-driver-v4-1-b5603f5458d8@oss.qualcomm.com> References: <20260224-lt8713sx-bridge-driver-v4-0-b5603f5458d8@oss.qualcomm.com> <20260224-lt8713sx-bridge-driver-v4-1-b5603f5458d8@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Missing `enable-gpios` property:** The driver calls `devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH)` but the binding does not document an `enable-gpios` property. If the hardware supports this GPIO, it must be documented in the binding. If it's not a real hardware signal, the driver shouldn't request it. **Supplies not required:** The `vcc-supply` and `vdd-supply` properties are defined but not listed in `required:`. The driver calls `devm_regulator_get_enable()` for both unconditionally (not optional), so either the bindings should mark them as required, or the driver should handle them being absent. Typically regulators are required: ```yaml + vcc-supply: + description: Regulator for 3.3V vcc. + + vdd-supply: + description: Regulator for 1.1V vdd. ``` These should be in the `required:` list if the driver mandates them. **`reset-gpios` not required:** Similarly, `reset-gpios` is not in `required:` but the driver does `devm_gpiod_get()` (not `_optional`), meaning it will fail if absent. It should be required in the binding: ```yaml + reset-gpios: + description: GPIO connected to active low RESET pin. ``` **Port descriptions are vague:** Ports 1, 2, and 3 all say "DP port for DP output from bridge" or "Additional DP port for DP output from bridge". Given the chip supports DP, HDMI, and DP++, the descriptions should clarify what each output actually is, or if they're truly generic, say so explicitly. **No `maxItems` on reset-gpios:** Standard practice is to add `maxItems: 1` to single GPIO properties. --- Generated by Claude Code Patch Reviewer