From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/qda: Add Qualcomm QDA DSP accelerator driver docs Date: Tue, 24 Feb 2026 18:20:10 +1000 Message-ID: In-Reply-To: <20260224-qda-firstpost-v1-1-fe46a9c1a046@oss.qualcomm.com> References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-1-fe46a9c1a046@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Documentation-only patch adding `Documentation/accel/qda/`. - The documentation claims QDA is a "modern replacement" but does not document the migration path from the existing interface. This is the most important thing users and downstream developers need to know. - The doc references IOCTLs (`DRM_IOCTL_QDA_QUERY`, etc.) that don't exist yet. While acceptable for RFC, the doc should be updated alongside the IOCTL patches or merged together. - As Dmitry noted: missing instructions on how to build and load DSP test applications. - Agree with Dmitry that MAINTAINERS entry (patch 18) should be in this patch. --- Generated by Claude Code Patch Reviewer