From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: alloc: add `KBox::into_nonnull`
Date: Fri, 27 Feb 2026 15:11:56 +1000 [thread overview]
Message-ID: <review-patch1-20260224-unique-ref-v16-1-c21afcb118d3@kernel.org> (raw)
In-Reply-To: <20260224-unique-ref-v16-1-c21afcb118d3@kernel.org>
Patch Review
Simple, clean utility method. No issues.
```rust
pub fn into_nonnull(b: Self) -> NonNull<T> {
// SAFETY: `KBox::into_raw` returns a valid pointer.
unsafe { NonNull::new_unchecked(Self::into_raw(b)) }
}
```
The SAFETY comment is correct — `KBox::into_raw` guarantees a non-null valid pointer (same contract as `Box::into_raw` in std).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 5:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 11:17 [PATCH v16 00/10] rust: add `Ownable` trait and `Owned` type Andreas Hindborg
2026-02-24 11:17 ` [PATCH v16 01/10] rust: alloc: add `KBox::into_nonnull` Andreas Hindborg
2026-02-27 5:11 ` Claude Code Review Bot [this message]
2026-02-24 11:17 ` [PATCH v16 02/10] rust: types: Add Ownable/Owned types Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-24 11:17 ` [PATCH v16 03/10] rust: rename `AlwaysRefCounted` to `RefCounted` Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-24 11:17 ` [PATCH v16 04/10] rust: Add missing SAFETY documentation for `ARef` example Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-24 11:18 ` [PATCH v16 05/10] rust: aref: update formatting of use statements Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-24 11:18 ` [PATCH v16 06/10] rust: Add `OwnableRefCounted` Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-24 11:18 ` [PATCH v16 07/10] rust: page: update formatting of `use` statements Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-24 11:18 ` [PATCH v16 08/10] rust: page: convert to `Ownable` Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-24 11:18 ` [PATCH v16 09/10] rust: implement `ForeignOwnable` for `Owned` Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-24 11:18 ` [PATCH v16 10/10] rust: page: add `from_raw()` Andreas Hindborg
2026-02-27 5:11 ` Claude review: " Claude Code Review Bot
2026-02-27 5:11 ` Claude review: rust: add `Ownable` trait and `Owned` type Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260224-unique-ref-v16-1-c21afcb118d3@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox