From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: platform/x86/intel/vsec: Refactor base_addr handling
Date: Fri, 27 Feb 2026 14:12:36 +1000 [thread overview]
Message-ID: <review-patch1-20260224-upstream-pmt-acpi-v5-v5-1-8dd73bcf049c@linux.intel.com> (raw)
In-Reply-To: <20260224-upstream-pmt-acpi-v5-v5-1-8dd73bcf049c@linux.intel.com>
Patch Review
**Overall: Clean, straightforward refactor.**
This patch removes the conditional `info->base_addr` vs `pdev->resource[header->tbir].start` logic from `intel_vsec_add_dev()` and instead passes `base_addr` as an explicit parameter all the way down the call chain. The callers now resolve the address: `intel_vsec_walk_header()` passes `info->base_addr`, while `intel_vsec_walk_dvsec()` and `intel_vsec_walk_vsec()` use `pci_resource_start()`.
This is a good preparation for making `info` const later and for ACPI paths where BAR lookups don't apply.
No issues found.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 4:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 1:50 [PATCH v5 0/6] platform/x86/intel/vsec: Prep for ACPI PMT discovery David E. Box
2026-02-25 1:50 ` [PATCH v5 1/6] platform/x86/intel/vsec: Refactor base_addr handling David E. Box
2026-02-27 4:12 ` Claude Code Review Bot [this message]
2026-02-25 1:50 ` [PATCH v5 2/6] platform/x86/intel/vsec: Make driver_data info const David E. Box
2026-02-27 4:12 ` Claude review: " Claude Code Review Bot
2026-02-25 1:50 ` [PATCH v5 3/6] platform/x86/intel/vsec: Decouple add/link helpers from PCI David E. Box
2026-02-27 4:12 ` Claude review: " Claude Code Review Bot
2026-02-25 1:50 ` [PATCH v5 4/6] platform/x86/intel/vsec: Switch exported helpers from pci_dev to device David E. Box
2026-02-27 4:12 ` Claude review: " Claude Code Review Bot
2026-02-25 1:50 ` [PATCH v5 5/6] platform/x86/intel/vsec: Return real error codes from registration path David E. Box
2026-02-27 4:12 ` Claude review: " Claude Code Review Bot
2026-02-25 1:50 ` [PATCH v5 6/6] platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec David E. Box
2026-02-27 4:12 ` Claude review: " Claude Code Review Bot
2026-02-27 4:12 ` Claude review: platform/x86/intel/vsec: Prep for ACPI PMT discovery Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260224-upstream-pmt-acpi-v5-v5-1-8dd73bcf049c@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox