From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: platform/x86/intel/vsec: Refactor base_addr handling Date: Fri, 27 Feb 2026 14:12:36 +1000 Message-ID: In-Reply-To: <20260224-upstream-pmt-acpi-v5-v5-1-8dd73bcf049c@linux.intel.com> References: <20260224-upstream-pmt-acpi-v5-v5-0-8dd73bcf049c@linux.intel.com> <20260224-upstream-pmt-acpi-v5-v5-1-8dd73bcf049c@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Overall: Clean, straightforward refactor.** This patch removes the conditional `info->base_addr` vs `pdev->resource[header->tbir].start` logic from `intel_vsec_add_dev()` and instead passes `base_addr` as an explicit parameter all the way down the call chain. The callers now resolve the address: `intel_vsec_walk_header()` passes `info->base_addr`, while `intel_vsec_walk_dvsec()` and `intel_vsec_walk_vsec()` use `pci_resource_start()`. This is a good preparation for making `info` const later and for ACPI paths where BAR lookups don't apply. No issues found. --- --- Generated by Claude Code Patch Reviewer