From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tests: Mark slow tests as slow Date: Fri, 27 Feb 2026 15:13:20 +1000 Message-ID: In-Reply-To: <20260224110310.1854608-1-mripard@kernel.org> References: <20260224110310.1854608-1-mripard@kernel.org> <20260224110310.1854608-1-mripard@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Reviewed files:** - `drivers/gpu/drm/scheduler/tests/tests_basic.c` =E2=80=94 two changes - `drivers/gpu/drm/tests/drm_buddy_test.c` =E2=80=94 one change All three changes are identical in nature: `KUNIT_CASE(...)` =E2=86=92 `KUN= IT_CASE_SLOW(...)`. **scheduler/tests/tests_basic.c:** ```c - KUNIT_CASE(drm_sched_change_priority), + KUNIT_CASE_SLOW(drm_sched_change_priority), ``` ```c - KUNIT_CASE(drm_sched_test_credits), + KUNIT_CASE_SLOW(drm_sched_test_credits), ``` Both are reasonable candidates. `drm_sched_change_priority` uses `usleep_ra= nge` polling loops and `drm_sched_test_credits` calls `drm_mock_sched_job_w= ait_finished(job, HZ)` which waits up to 1 second by design, so it can plau= sibly cross the threshold. **tests/drm_buddy_test.c:** ```c - KUNIT_CASE(drm_test_buddy_fragmentation_performance), + KUNIT_CASE_SLOW(drm_test_buddy_fragmentation_performance), ``` A performance/stress test is a natural candidate for the slow annotation. **Minor observation:** The commit message says tests "cross the 1s executio= n time threshold" but doesn't mention which specific tests or on what hardw= are. This is fine for a patch of this scope, but if reviewers want reproduc= ibility context, it could be worth noting whether these were measured on a = particular CI system. This is not a blocker. **Verdict:** Patch looks good. Reviewed-by: AI Review --- Generated by Claude Code Patch Reviewer