From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vblank: Add drm_crtc_vblank_is_off() helper
Date: Fri, 27 Feb 2026 14:40:52 +1000 [thread overview]
Message-ID: <review-patch1-20260224212639.390768-2-sunpeng.li@amd.com> (raw)
In-Reply-To: <20260224212639.390768-2-sunpeng.li@amd.com>
Patch Review
**Generally clean.** The refactoring correctly replaces the `drm_crtc_vblank_get()` + check return value pattern with a direct state query, removing the need for a balancing `drm_crtc_vblank_put()`.
The condition in `drm_crtc_vblank_is_off()`:
```c
guard(spinlock_irqsave)(&crtc->dev->vbl_lock);
return vblank->inmodeset && !vblank->enabled;
```
correctly captures the "vblank_off was called" state — `inmodeset` is set in `drm_crtc_vblank_off()` when it bumps the refcount, and `enabled` is cleared by `drm_vblank_disable_and_save()`. This is semantically what the original code was checking.
**Minor issues:**
1. The function is declared in `drm_internal.h` but uses `EXPORT_SYMBOL`. This is needed because `drm_atomic_helper.c` compiles into a separate module (`drm_kms_helper`), but it's a slightly awkward pattern — an exported symbol with no public header declaration. Consider whether a public header (e.g., `drm_vblank.h`) would be more appropriate if other drivers/helpers might eventually need this.
2. The kdoc says "Return False otherwise" with a capital 'F' — should be lowercase "false" for consistency.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 4:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 21:26 [PATCH 0/5] drm/vblank: Deferred Enable and Disable sunpeng.li
2026-02-24 21:26 ` [PATCH 1/5] drm/vblank: Add drm_crtc_vblank_is_off() helper sunpeng.li
2026-02-27 4:40 ` Claude Code Review Bot [this message]
2026-02-24 21:26 ` [PATCH 2/5] drm/vblank: Introduce deferred vblank enable/disable sunpeng.li
2026-02-25 4:42 ` kernel test robot
2026-02-27 4:40 ` Claude review: " Claude Code Review Bot
2026-02-24 21:26 ` [PATCH 3/5] drm/amd/display: Refactor amdgpu_dm_crtc_set_vblank sunpeng.li
2026-02-27 4:40 ` Claude review: " Claude Code Review Bot
2026-02-24 21:26 ` [PATCH 4/5] drm/amd/display: Implement deferred vblanks on IPS platforms sunpeng.li
2026-02-27 4:40 ` Claude review: " Claude Code Review Bot
2026-02-24 21:26 ` [PATCH 5/5] drm/vblank: Add some debugging trace events sunpeng.li
2026-02-27 4:40 ` Claude review: " Claude Code Review Bot
2026-02-27 4:40 ` Claude review: drm/vblank: Deferred Enable and Disable Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-23 20:27 [PATCH v2 0/5] " sunpeng.li
2026-03-23 20:27 ` [PATCH v2 1/5] drm/vblank: Add drm_crtc_vblank_is_off() helper sunpeng.li
2026-03-24 21:22 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260224212639.390768-2-sunpeng.li@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox