From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: ffi: Convert pub use to pub mod and create ffi module
Date: Fri, 27 Feb 2026 14:34:27 +1000 [thread overview]
Message-ID: <review-patch1-20260224222734.3153931-2-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20260224222734.3153931-2-joelagnelf@nvidia.com>
Patch Review
This patch converts `pub use ffi;` to `pub mod ffi;` in `lib.rs` and creates `rust/kernel/ffi/mod.rs` that re-exports everything from the `ffi` crate via `pub use ::ffi::*;`.
**Looks good overall.** A few minor observations:
1. The `pub use ffi;` line at line 65 of the current `lib.rs` is being replaced by `pub mod ffi;` inserted in alphabetical order among the other `pub mod` declarations. This is correct and clean.
2. The re-export via `pub use ::ffi::*;` in `mod.rs` preserves backward compatibility for `kernel::ffi::c_int` etc. This is the right approach.
No issues with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 4:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 22:27 [PATCH v11 0/2] rust: clist patches for nova-core memory management Joel Fernandes
2026-02-24 22:27 ` [PATCH v11 1/2] rust: ffi: Convert pub use to pub mod and create ffi module Joel Fernandes
2026-02-27 4:34 ` Claude Code Review Bot [this message]
2026-02-24 22:27 ` [PATCH v11 2/2] rust: clist: Add support to interface with C linked lists Joel Fernandes
2026-02-25 8:09 ` Alexandre Courbot
2026-02-25 8:25 ` Alexandre Courbot
2026-02-26 0:24 ` Joel Fernandes
2026-02-26 16:23 ` Alvin Sun
2026-02-26 19:34 ` Joel Fernandes
2026-02-27 4:34 ` Claude review: " Claude Code Review Bot
2026-02-27 4:34 ` Claude review: rust: clist patches for nova-core memory management Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260224222734.3153931-2-joelagnelf@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox