From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: ffi: Convert pub use to pub mod and create ffi module Date: Fri, 27 Feb 2026 14:34:27 +1000 Message-ID: In-Reply-To: <20260224222734.3153931-2-joelagnelf@nvidia.com> References: <20260224222734.3153931-1-joelagnelf@nvidia.com> <20260224222734.3153931-2-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch converts `pub use ffi;` to `pub mod ffi;` in `lib.rs` and creates `rust/kernel/ffi/mod.rs` that re-exports everything from the `ffi` crate via `pub use ::ffi::*;`. **Looks good overall.** A few minor observations: 1. The `pub use ffi;` line at line 65 of the current `lib.rs` is being replaced by `pub mod ffi;` inserted in alphabetical order among the other `pub mod` declarations. This is correct and clean. 2. The re-export via `pub use ::ffi::*;` in `mod.rs` preserves backward compatibility for `kernel::ffi::c_int` etc. This is the right approach. No issues with this patch. --- Generated by Claude Code Patch Reviewer