From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: fix stale doc comments on command queue methods Date: Fri, 27 Feb 2026 13:18:04 +1000 Message-ID: In-Reply-To: <20260225-cmdq-locking-v1-1-bbf6b4156706@nvidia.com> References: <20260225-cmdq-locking-v1-0-bbf6b4156706@nvidia.com> <20260225-cmdq-locking-v1-1-bbf6b4156706@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Simple doc comment cleanup. This is a straightforward improvement. The changes are accurate: - Adding `EMSGSIZE` to the error docs for `send_command` (presumably added by the prerequisite split series). - Replacing the outdated description of `receive_msg` with accurate behavior: it now returns `ERANGE` (not `EAGAIN`) for non-matching function codes, and the read pointer is always advanced. - Changing `EINVAL` wording from "unrecognized" to "not recognized" and adding `ERANGE` for recognized-but-non-matching. - Adding note about `MessageFromGsp::read` error propagation. No issues. **Reviewed-by worthy.** --- --- Generated by Claude Code Patch Reviewer