From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: ARM: dts: microchip: sama7d65: add LCD controller
Date: Fri, 27 Feb 2026 13:48:29 +1000 [thread overview]
Message-ID: <review-patch1-20260225085430.480052-2-manikandan.m@microchip.com> (raw)
In-Reply-To: <20260225085430.480052-2-manikandan.m@microchip.com>
Patch Review
**Critical issue — missing fallback compatible will break DRM probe:**
The DRM display controller driver at `drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c:766` does:
```c
match = of_match_node(atmel_hlcdc_of_match, dev->dev->parent->of_node);
```
The `atmel_hlcdc_of_match` table (line 569–598) contains `"microchip,sam9x75-xlcdc"` but **not** `"microchip,sama7d65-xlcdc"`. This means the DRM probe will fail with `"invalid compatible string"` and the display won't work.
The LVDS node in patch 3 correctly uses a fallback compatible (`"microchip,sama7d65-lvds", "microchip,sam9x75-lvds"`), but this LCD node does not. The fix is either:
- Add a fallback compatible: `compatible = "microchip,sama7d65-xlcdc", "microchip,sam9x75-xlcdc";` (and update the MFD binding to match this pattern), or
- Include a separate patch adding `sama7d65-xlcdc` to the DRM driver's match table with appropriate data
**Style issue — missing space before `{`:**
```
+ xlcdc: lcd-controller@e1400000{
```
Should be:
```
xlcdc: lcd-controller@e1400000 {
```
The node content itself looks correct: reg, interrupts, clocks, clock-names, display-controller subnode, and pwm subnode all follow the existing pattern from `sam9x7.dtsi`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 3:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 8:54 [PATCH 0/6] Add LCD and LVDS controller for sama7d65 SoC Manikandan Muralidharan
2026-02-25 8:54 ` [PATCH 1/6] ARM: dts: microchip: sama7d65: add LCD controller Manikandan Muralidharan
2026-02-27 3:48 ` Claude Code Review Bot [this message]
2026-02-25 8:54 ` [PATCH 2/6] dt-bindings: display: bridge: microchip, sam9x75-lvds: document SAMA7D65 binding Manikandan Muralidharan
2026-02-26 7:44 ` [PATCH 2/6] dt-bindings: display: bridge: microchip,sam9x75-lvds: " Krzysztof Kozlowski
2026-02-27 3:48 ` Claude review: dt-bindings: display: bridge: microchip, sam9x75-lvds: " Claude Code Review Bot
2026-02-25 8:54 ` [PATCH 3/6] ARM: dts: microchip: sama7d65: add LVDS controller Manikandan Muralidharan
2026-02-27 3:48 ` Claude review: " Claude Code Review Bot
2026-02-25 8:54 ` [PATCH 4/6] ARM: configs: at91: sama7: enable DRM hlcdc support Manikandan Muralidharan
2026-02-27 3:48 ` Claude review: " Claude Code Review Bot
2026-02-25 8:54 ` [PATCH 5/6] ARM: configs: at91: sama7: enable config for atmel maxtouch Manikandan Muralidharan
2026-02-27 3:48 ` Claude review: " Claude Code Review Bot
2026-02-25 8:54 ` [PATCH 6/6] ARM: configs: at91: sama7: enable LVDS serializer support Manikandan Muralidharan
2026-02-27 3:48 ` Claude review: " Claude Code Review Bot
2026-02-27 3:48 ` Claude review: Add LCD and LVDS controller for sama7d65 SoC Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260225085430.480052-2-manikandan.m@microchip.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox