From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: dts: microchip: sama7d65: add LCD controller Date: Fri, 27 Feb 2026 13:48:29 +1000 Message-ID: In-Reply-To: <20260225085430.480052-2-manikandan.m@microchip.com> References: <20260225085430.480052-1-manikandan.m@microchip.com> <20260225085430.480052-2-manikandan.m@microchip.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Critical issue =E2=80=94 missing fallback compatible will break DRM probe= :** The DRM display controller driver at `drivers/gpu/drm/atmel-hlcdc/atmel_hlc= dc_dc.c:766` does: ```c match =3D of_match_node(atmel_hlcdc_of_match, dev->dev->parent->of_node); ``` The `atmel_hlcdc_of_match` table (line 569=E2=80=93598) contains `"microchi= p,sam9x75-xlcdc"` but **not** `"microchip,sama7d65-xlcdc"`. This means the = DRM probe will fail with `"invalid compatible string"` and the display won'= t work. The LVDS node in patch 3 correctly uses a fallback compatible (`"microchip,= sama7d65-lvds", "microchip,sam9x75-lvds"`), but this LCD node does not. The= fix is either: - Add a fallback compatible: `compatible =3D "microchip,sama7d65-xlcdc", "m= icrochip,sam9x75-xlcdc";` (and update the MFD binding to match this pattern= ), or - Include a separate patch adding `sama7d65-xlcdc` to the DRM driver's matc= h table with appropriate data **Style issue =E2=80=94 missing space before `{`:** ``` + xlcdc: lcd-controller@e1400000{ ``` Should be: ``` xlcdc: lcd-controller@e1400000 { ``` The node content itself looks correct: reg, interrupts, clocks, clock-names= , display-controller subnode, and pwm subnode all follow the existing patte= rn from `sam9x7.dtsi`. --- Generated by Claude Code Patch Reviewer