From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] staging: fbtft: fb_ra8875: replace udelays with usleep_range
Date: Fri, 27 Feb 2026 12:54:37 +1000 [thread overview]
Message-ID: <review-patch1-2026022515-booth-silent-f3bd@gregkh> (raw)
In-Reply-To: <2026022515-booth-silent-f3bd@gregkh>
Patch Review
**Status**: Superseded by v2.
The v1 approach of `usleep_range(100, 120)` is functionally correct — this is a non-atomic context (confirmed by the SPI write calls surrounding the delays). However, for a 100us delay, `fsleep()` is the more modern and idiomatic choice since it automatically picks the right mechanism based on duration. The 20us upper bound (20% range) is reasonable but a bit narrow for a 100us delay.
This patch was correctly revised in v2.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 2:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 20:45 [PATCH] staging: fbtft: fb_ra8875: replace udelays with usleep_range Jose A. Perez de Azpillaga
2026-02-25 21:14 ` Greg KH
2026-02-27 2:43 ` Claude review: " Claude Code Review Bot
2026-02-27 2:54 ` Claude Code Review Bot [this message]
2026-02-25 23:40 ` [PATCH v2] staging: fbtft: fb_ra8875: replace udelays with fsleep Jose A. Perez de Azpillaga
2026-02-26 7:46 ` Andy Shevchenko
2026-02-26 8:31 ` Jose A. Perez de Azpillaga
2026-02-27 2:54 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-2026022515-booth-silent-f3bd@gregkh \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox