public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Add pixel_clock to amd_pp_display_configuration
Date: Fri, 27 Feb 2026 12:46:57 +1000	[thread overview]
Message-ID: <review-patch1-20260225215013.11224-2-rosenp@gmail.com> (raw)
In-Reply-To: <20260225215013.11224-2-rosenp@gmail.com>

Patch Review

Clean, minimal patch. Adds the `pixel_clock` field to two structs and wires up the data flow.

The rename of `sym_clock` to `pixel_clock` in `dm_services_types.h`:
```c
-	uint32_t sym_clock; /* HDMI only */
+	uint32_t pixel_clock; /* Pixel clock in KHz (for HDMI only: normalized) */
```
is correct and matches the upstream commit. The old field name was misleading since "sym_clock" typically refers to the DisplayPort symbol clock.

The addition of `pixel_clock` to `single_display_configuration` in `dm_pp_interface.h`:
```c
+	uint32_t pixel_clock; /* Pixel clock in KHz (for HDMI only: normalized) */
```
and the corresponding propagation in `amdgpu_dm_pp_smu.c`:
```c
+			adev->pm.pm_display_cfg.displays[i].pixel_clock = dc_cfg->pixel_clock;
```
and the assignment in `dce110_clk_mgr.c`:
```c
-		cfg->sym_clock = stream->phy_pix_clk;
+		cfg->pixel_clock = stream->phy_pix_clk;
```
are all straightforward.

No issues with this patch.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-27  2:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 21:50 [PATCH for 6.12 and 6.6 0/2] amdgpu: fix panic on old GPUs Rosen Penev
2026-02-25 21:50 ` [PATCH 1/2] drm/amd/display: Add pixel_clock to amd_pp_display_configuration Rosen Penev
2026-02-27  2:46   ` Claude Code Review Bot [this message]
2026-02-25 21:50 ` [PATCH 2/2] drm/amd/pm: Use pm_display_cfg in legacy DPM (v2) Rosen Penev
2026-02-27  2:46   ` Claude review: " Claude Code Review Bot
2026-02-27  2:46 ` Claude review: amdgpu: fix panic on old GPUs Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260225215013.11224-2-rosenp@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox