From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Add pixel_clock to amd_pp_display_configuration Date: Fri, 27 Feb 2026 12:46:57 +1000 Message-ID: In-Reply-To: <20260225215013.11224-2-rosenp@gmail.com> References: <20260225215013.11224-1-rosenp@gmail.com> <20260225215013.11224-2-rosenp@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean, minimal patch. Adds the `pixel_clock` field to two structs and wires up the data flow. The rename of `sym_clock` to `pixel_clock` in `dm_services_types.h`: ```c - uint32_t sym_clock; /* HDMI only */ + uint32_t pixel_clock; /* Pixel clock in KHz (for HDMI only: normalized) */ ``` is correct and matches the upstream commit. The old field name was misleading since "sym_clock" typically refers to the DisplayPort symbol clock. The addition of `pixel_clock` to `single_display_configuration` in `dm_pp_interface.h`: ```c + uint32_t pixel_clock; /* Pixel clock in KHz (for HDMI only: normalized) */ ``` and the corresponding propagation in `amdgpu_dm_pp_smu.c`: ```c + adev->pm.pm_display_cfg.displays[i].pixel_clock = dc_cfg->pixel_clock; ``` and the assignment in `dce110_clk_mgr.c`: ```c - cfg->sym_clock = stream->phy_pix_clk; + cfg->pixel_clock = stream->phy_pix_clk; ``` are all straightforward. No issues with this patch. --- Generated by Claude Code Patch Reviewer