public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: amdgpu/display/dc/link: fix sparse warning on assigning int as nullptr
Date: Fri, 27 Feb 2026 12:41:48 +1000	[thread overview]
Message-ID: <review-patch1-20260225234707.37597-1-jpeisach@ubuntu.com> (raw)
In-Reply-To: <20260225234707.37597-1-jpeisach@ubuntu.com>

Patch Review

**Status: Correct and appropriate.**

The patch changes:
```c
-	struct dc_stream_state *link_stream = 0;
+	struct dc_stream_state *link_stream = NULL;
```

This is a straightforward fix. Assigning `0` to a pointer is valid C but triggers a sparse warning because sparse distinguishes between integer zero and the `NULL` pointer constant. Using `NULL` is the idiomatic and preferred style in the kernel.

**Minor nits on the commit message:**

1. The subject prefix uses `amdgpu/display/dc/link:` but the conventional prefix for this subsystem in the kernel log would be `drm/amd/display:` or `drm/amd/display/dc/link:`. Looking at recent commits for this file, the `drm/amd/` prefix is standard. This should ideally be `drm/amd/display: fix sparse warning ...`.

2. The commit message body says "nullptr" which is a C++ term — the kernel uses C, where it's simply `NULL`. The body could be slightly more precise, e.g., "Fix sparse warning about assigning plain 0 to pointer variable; use NULL instead."

3. The commit message body lacks a `Fixes:` tag identifying when the offending code was introduced. While not strictly required for a style/warning fix, it can be helpful.

None of these are blocking issues — the code change itself is clearly correct and trivially safe.

**Reviewed-by: Acceptable.**

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-27  2:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 23:46 [PATCH] amdgpu/display/dc/link: fix sparse warning on assigning int as nullptr Joshua Peisach
2026-02-27  2:41 ` Claude review: " Claude Code Review Bot
2026-02-27  2:41 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260225234707.37597-1-jpeisach@ubuntu.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox