public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: fix stale doc comments on command queue methods
Date: Fri, 27 Feb 2026 12:04:08 +1000	[thread overview]
Message-ID: <review-patch1-20260226-cmdq-locking-v2-1-c7e16a6d5885@nvidia.com> (raw)
In-Reply-To: <20260226-cmdq-locking-v2-1-c7e16a6d5885@nvidia.com>

Patch Review

**Status: Looks good**

A straightforward documentation cleanup. The changes are:

1. Adding missing `EMSGSIZE` error doc:
```
+    /// - `EMSGSIZE` if the command exceeds the maximum queue element size.
```
This was presumably missing from the original docs — good to add.

2. Updating `receive_msg` docs to accurately describe current behavior:
```
-    /// `init` is a closure tasked with processing the message...
+    /// The expected message type is specified using the `M` generic parameter. If the pending
+    /// message has a different function code, `ERANGE` is returned and the message is consumed.
```
The old docs referenced a closure-based API that no longer exists. The replacement accurately describes the current generic-parameter approach.

3. Updating error code documentation:
```
-    /// - `EINVAL` if the function of the message was unrecognized.
+    /// - `EINVAL` if the function code of the message was not recognized.
+    /// - `ERANGE` if the message had a recognized but non-matching function code.
```
The `EAGAIN` → `ERANGE` distinction and the addition of `ERANGE` docs are correct.

4. Adding note about error propagation:
```
+    /// Error codes returned by [`MessageFromGsp::read`] are propagated as-is.
```

5. Removing the "this design is by no means final" comment — appropriate for a maturing codebase.

No issues. Already has Reviewed-by from Zhi Wang.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-27  2:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 14:50 [PATCH v2 0/4] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-02-26 14:50 ` [PATCH v2 1/4] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-02-27  2:04   ` Claude Code Review Bot [this message]
2026-02-26 14:50 ` [PATCH v2 2/4] gpu: nova-core: gsp: add sync and async command queue API to `Cmdq` Eliot Courtney
2026-02-27  2:04   ` Claude review: " Claude Code Review Bot
2026-02-26 14:50 ` [PATCH v2 3/4] gpu: nova-core: gsp: make `Cmdq` a pinned type Eliot Courtney
2026-02-27  2:04   ` Claude review: " Claude Code Review Bot
2026-02-26 14:50 ` [PATCH v2 4/4] gpu: nova-core: gsp: add mutex locking to Cmdq Eliot Courtney
2026-02-27  2:04   ` Claude review: " Claude Code Review Bot
2026-02-26 18:48 ` [PATCH v2 0/4] gpu: nova-core: gsp: add " Zhi Wang
2026-02-27  2:04 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10  8:09 [PATCH v4 0/5] " Eliot Courtney
2026-03-10  8:09 ` [PATCH v4 1/5] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-03-11  3:32   ` Claude review: " Claude Code Review Bot
2026-03-04  2:46 [PATCH v3 0/5] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-03-04  2:46 ` [PATCH v3 1/5] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-03-05  3:52   ` Claude review: " Claude Code Review Bot
2026-02-25 13:41 [PATCH 0/4] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-02-25 13:41 ` [PATCH 1/4] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-02-27  3:18   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260226-cmdq-locking-v2-1-c7e16a6d5885@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox