From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: fix stale doc comments on command queue methods Date: Fri, 27 Feb 2026 12:04:08 +1000 Message-ID: In-Reply-To: <20260226-cmdq-locking-v2-1-c7e16a6d5885@nvidia.com> References: <20260226-cmdq-locking-v2-0-c7e16a6d5885@nvidia.com> <20260226-cmdq-locking-v2-1-c7e16a6d5885@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good** A straightforward documentation cleanup. The changes are: 1. Adding missing `EMSGSIZE` error doc: ``` + /// - `EMSGSIZE` if the command exceeds the maximum queue element size. ``` This was presumably missing from the original docs =E2=80=94 good to add. 2. Updating `receive_msg` docs to accurately describe current behavior: ``` - /// `init` is a closure tasked with processing the message... + /// The expected message type is specified using the `M` generic param= eter. If the pending + /// message has a different function code, `ERANGE` is returned and th= e message is consumed. ``` The old docs referenced a closure-based API that no longer exists. The repl= acement accurately describes the current generic-parameter approach. 3. Updating error code documentation: ``` - /// - `EINVAL` if the function of the message was unrecognized. + /// - `EINVAL` if the function code of the message was not recognized. + /// - `ERANGE` if the message had a recognized but non-matching functi= on code. ``` The `EAGAIN` =E2=86=92 `ERANGE` distinction and the addition of `ERANGE` do= cs are correct. 4. Adding note about error propagation: ``` + /// Error codes returned by [`MessageFromGsp::read`] are propagated as= -is. ``` 5. Removing the "this design is by no means final" comment =E2=80=94 approp= riate for a maturing codebase. No issues. Already has Reviewed-by from Zhi Wang. --- --- Generated by Claude Code Patch Reviewer