From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: Clean up SOFEF00 config dependencies
Date: Fri, 27 Feb 2026 12:17:12 +1000
Message-ID: <review-patch1-20260226-panel-clean-up-kconfig-dep-v1-1-bb28a2355b4c@ixit.cz>
In-Reply-To: <20260226-panel-clean-up-kconfig-dep-v1-1-bb28a2355b4c@ixit.cz>
References: <20260226-panel-clean-up-kconfig-dep-v1-0-bb28a2355b4c@ixit.cz> <20260226-panel-clean-up-kconfig-dep-v1-1-bb28a2355b4c@ixit.cz>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Author:** Marijn Suijten

This patch removes `select VIDEOMODE_HELPERS` and adds `depends on GPIOLIB` to `DRM_PANEL_SAMSUNG_SOFEF00`.

Verified in `panel-samsung-sofef00.c`:
- Uses `devm_gpiod_get()` and `gpiod_set_value_cansleep()` - GPIOLIB dependency is correct
- Does not include `<video/videomode.h>` or use any videomode helper functions - removing `select VIDEOMODE_HELPERS` is correct
- The driver defines `drm_display_mode` directly, not via `display_timing` conversion

The `depends on GPIOLIB` is placed before the existing `depends on OF` line, which is a reasonable ordering (alphabetical would put GPIOLIB first anyway since it comes after BACKLIGHT but before OF - though there's no strict convention here).

**Reviewed-by tags present from Neil Armstrong, Casey Connolly, and David Heidelberg.**

**No issues.** Looks good.

---

---
Generated by Claude Code Patch Reviewer