Claude review: drm/bridge: dw-hdmi: Replace calls to deprecated HDMI/audio detection functions

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Subject line is misleading.** The commit message says "Replace calls to deprecated...functions", but the patch only *removes* the old calls — it does not replace anything. The consumers are left reading stale (always-false) fields.

**Critical: Remaining consumers not updated.** After this patch, the following code still references the now-never-assigned fields:

1. `dw-hdmi.c:2061` — `hdmi_av_composer()`:
   ```c
   inv_val |= hdmi->sink_is_hdmi ?
       HDMI_FC_INVIDCONF_DVI_MODEZ_HDMI_MODE :
       HDMI_FC_INVIDCONF_DVI_MODEZ_DVI_MODE;
   ```
   Will always select DVI mode.

2. `dw-hdmi.c:2294` — `dw_hdmi_setup()`:
   ```c
   hdmi->hdmi_data.rgb_limited_range = hdmi->sink_is_hdmi &&
       drm_default_rgb_quant_range(mode) ==
       HDMI_QUANTIZATION_RANGE_LIMITED;
   ```
   Will always set `rgb_limited_range = false`.

3. `dw-hdmi.c:2316` — `dw_hdmi_setup()`:
   ```c
   if (hdmi->sink_has_audio) {
   ```
   Audio will never be configured.

4. `dw-hdmi.c:2325` — `dw_hdmi_setup()`:
   ```c
   if (hdmi->sink_is_hdmi) {
   ```
   AVI InfoFrame, vendor-specific infoframe, and DRM infoframe configuration will be skipped entirely.

**What a correct patch would need to do:**
- Remove the `sink_is_hdmi` and `sink_has_audio` fields from `struct dw_hdmi` (lines 161-162).
- Change all four consumer sites to read from `connector->display_info.is_hdmi` and `connector->display_info.has_audio` instead. Note that `dw_hdmi_setup()` and `hdmi_av_composer()` already receive a `const struct drm_connector *connector` parameter (or `const struct drm_display_info *display`), so the information is accessible — it just needs to be wired up.

**Additional note on the bridge path:** When dw-hdmi operates via `dw_hdmi_bridge_edid_read()` (line 2990), the bridge framework calls `drm_edid_connector_update()` on behalf of the caller, so the approach is sound — but only if the consumers are updated.

**Minor:** The removed `dev_dbg` logging of EDID width/height (useful for debug) could be kept or moved, but this is cosmetic and not a blocker.

---
Generated by Claude Code Patch Reviewer