From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dsi/phy: fix hardware revision Date: Fri, 27 Feb 2026 12:11:26 +1000 Message-ID: In-Reply-To: <20260226122958.22555-2-mitltlatltl@gmail.com> References: <20260226122958.22555-1-mitltlatltl@gmail.com> <20260226122958.22555-2-mitltlatltl@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Summary:** Renames `DSI_PHY_7NM_QUIRK_V7_0` to `DSI_PHY_7NM_QUIRK_V7_2` a= cross all uses, including the define, all conditional checks, and both PHY = config structures (`dsi_phy_3nm_8750_cfgs` and `dsi_phy_3nm_kaanapali_cfgs`= ). The commit message explains the rationale well =E2=80=94 `REG_DSI_7nm_PHY_C= MN_REVISION_ID0` returns `0x27`, indicating revision 7.2. The `Fixes:` tag referencing commit `1337d7ebfb6d ("drm/msm/dsi/phy: Add su= pport for SM8750")` is appropriate since that's where `V7_0` was introduced. The rename is mechanically complete across all 9 code locations and both co= nfig structs. **Issue =E2=80=94 stale comment not updated:** At line 701 in the patched file, the comment still references "v7.0": ```c /* v7.0: Enable ATB_EN0 and alternate clock output to external phy */ if (phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V7_2) ``` This should be updated to `/* v7.2: ... */` to match the rename. The patch = updated the define comment (`/* Hardware is V7.2 */`) but missed this inlin= e comment. **Minor style nit:** Several conditions use double parentheses around singl= e bitwise-AND tests, e.g.: ```c } else if ((pll->phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V7_2)) { ``` and: ```c if ((phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V7_2)) { ``` These extra parens are pre-existing and not introduced by this patch, so no= t a blocker, but worth noting. --- Generated by Claude Code Patch Reviewer