From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel: Arm Ethos-U NPU: fix all uapi kernel-doc warnings
Date: Fri, 27 Feb 2026 11:37:36 +1000 [thread overview]
Message-ID: <review-patch1-20260226215823.989380-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260226215823.989380-1-rdunlap@infradead.org>
Patch Review
**Correctness: All changes verified against the actual struct definitions.**
1. **Struct name fixes** — Both are clearly correct:
- `struct drm_ethosu_gpu_info` → `struct drm_ethosu_npu_info` (matches actual struct at line 67)
- `struct drm_ethosu_wait_bo` → `struct drm_ethosu_bo_wait` (matches actual struct at line 170)
2. **Member name fix** — Correct:
- `@gpu_rev: GPU revision.` → `@config: NPU revision.` — the field is indeed named `config`, not `gpu_rev`
3. **Added missing member docs** — All correct and follow existing style:
- `@sram_size` in `drm_ethosu_npu_info`
- `@handle`, `@pad`, `@timeout_ns` in `drm_ethosu_bo_wait`
4. **Added `@member:` prefixes** to existing comments — Correct for:
- `@cmd_bo`, `@sram_size`, `@region_bo_handles` in `drm_ethosu_job`
- `@jobs`, `@job_count`, `@pad` in `drm_ethosu_submit`
**Minor nit (not worth a respin):** The added `@sram_size` doc at line 81:
```c
/** @sram_size: NPU SRAM size (KB) */
```
is missing a trailing period, while the adjacent `@config` line has one:
```c
/** @config: NPU revision. */
```
This is cosmetic and inconsistency exists elsewhere in the file, so not worth blocking on.
**One question to consider:** The description `@config: NPU revision.` — "NPU revision" was carried over from the original `@gpu_rev: GPU revision.` description. Whether "revision" is the most accurate description for a field named `config` is debatable, but it's what was already there (modulo the GPU→NPU correction), and the original author of the struct presumably had a reason. This is fine as-is.
**Reviewed-by worthy.** No issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-27 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 21:58 [PATCH] accel: Arm Ethos-U NPU: fix all uapi kernel-doc warnings Randy Dunlap
2026-02-27 1:37 ` Claude review: " Claude Code Review Bot
2026-02-27 1:37 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260226215823.989380-1-rdunlap@infradead.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox