From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel: Arm Ethos-U NPU: fix all uapi kernel-doc warnings Date: Fri, 27 Feb 2026 11:37:36 +1000 Message-ID: In-Reply-To: <20260226215823.989380-1-rdunlap@infradead.org> References: <20260226215823.989380-1-rdunlap@infradead.org> <20260226215823.989380-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: All changes verified against the actual struct definitions.** 1. **Struct name fixes** =E2=80=94 Both are clearly correct: - `struct drm_ethosu_gpu_info` =E2=86=92 `struct drm_ethosu_npu_info` (m= atches actual struct at line 67) - `struct drm_ethosu_wait_bo` =E2=86=92 `struct drm_ethosu_bo_wait` (mat= ches actual struct at line 170) 2. **Member name fix** =E2=80=94 Correct: - `@gpu_rev: GPU revision.` =E2=86=92 `@config: NPU revision.` =E2=80=94= the field is indeed named `config`, not `gpu_rev` 3. **Added missing member docs** =E2=80=94 All correct and follow existing = style: - `@sram_size` in `drm_ethosu_npu_info` - `@handle`, `@pad`, `@timeout_ns` in `drm_ethosu_bo_wait` 4. **Added `@member:` prefixes** to existing comments =E2=80=94 Correct for: - `@cmd_bo`, `@sram_size`, `@region_bo_handles` in `drm_ethosu_job` - `@jobs`, `@job_count`, `@pad` in `drm_ethosu_submit` **Minor nit (not worth a respin):** The added `@sram_size` doc at line 81: ```c /** @sram_size: NPU SRAM size (KB) */ ``` is missing a trailing period, while the adjacent `@config` line has one: ```c /** @config: NPU revision. */ ``` This is cosmetic and inconsistency exists elsewhere in the file, so not wor= th blocking on. **One question to consider:** The description `@config: NPU revision.` =E2= =80=94 "NPU revision" was carried over from the original `@gpu_rev: GPU rev= ision.` description. Whether "revision" is the most accurate description fo= r a field named `config` is debatable, but it's what was already there (mod= ulo the GPU=E2=86=92NPU correction), and the original author of the struct = presumably had a reason. This is fine as-is. **Reviewed-by worthy.** No issues found. --- Generated by Claude Code Patch Reviewer