public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: tegra_drm.h: fix all uapi kernel-doc warnings
Date: Fri, 27 Feb 2026 11:38:41 +1000	[thread overview]
Message-ID: <review-patch1-20260226215833.989397-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260226215833.989397-1-rdunlap@infradead.org>

Patch Review

**Fix 1 & 2: Add missing struct member descriptions**

```c
 struct drm_tegra_reloc {
+	/** @cmdbuf: cmd information */
 	struct {
```

```c
 	} cmdbuf;
+	/** @target: relocate target information */
 	struct {
```

These additions are correct. The `struct drm_tegra_reloc` has kernel-doc (`/** ... */`) on the struct itself, and the nested anonymous struct members `cmdbuf.handle`, `cmdbuf.offset`, etc. are all documented, but the top-level `cmdbuf` and `target` aggregate members themselves were not. kernel-doc requires all direct struct members to be documented, so adding these one-line descriptions fixes the warnings.

Minor nit: the descriptions are somewhat terse ("cmd information", "relocate target information") — they could be slightly more descriptive (e.g., "command buffer reference" and "relocation target reference"), but this is a very minor style preference and not a blocker. The existing sub-member docs already provide the detail.

**Fix 3–6: Demote `/**` to `/*` on `#define` comments**

```c
-/**
+/*
  * Specify that bit 39 of the patched-in address should be set to switch
```

```c
-/**
+/*
  * Execute `words` words of Host1x opcodes specified in the `gather_data_ptr`
```

```c
-/**
+/*
  * Wait for a syncpoint to reach a value before continuing with further
  * commands.
```

```c
-/**
+/*
  * Wait for a syncpoint to reach a value before continuing with further
  * commands. The threshold is calculated relative to the start of the job.
```

All four are correct. `/**` signals kernel-doc format, which requires specific structured syntax (e.g., `@param:` descriptions for function parameters, or `DOC:` sections). These are free-form comments on `#define` macros, so `/*` is the appropriate style. The change silences the warnings without losing any documentation content.

**Reviewed-by: No issues found.** The patch is correct and ready to merge.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-27  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 21:58 [PATCH] drm/tegra: tegra_drm.h: fix all uapi kernel-doc warnings Randy Dunlap
2026-02-27  1:38 ` Claude review: " Claude Code Review Bot
2026-02-27  1:38 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-04  1:41 [PATCH v2] " Randy Dunlap
2026-03-05  3:56 ` Claude review: " Claude Code Review Bot
2026-03-05  3:56 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260226215833.989397-1-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox