From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: tegra_drm.h: fix all uapi kernel-doc warnings
Date: Fri, 27 Feb 2026 11:38:41 +1000
Message-ID: <review-patch1-20260226215833.989397-1-rdunlap@infradead.org>
In-Reply-To: <20260226215833.989397-1-rdunlap@infradead.org>
References: <20260226215833.989397-1-rdunlap@infradead.org> <20260226215833.989397-1-rdunlap@infradead.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Fix 1 & 2: Add missing struct member descriptions**

```c
 struct drm_tegra_reloc {
+	/** @cmdbuf: cmd information */
 	struct {
```

```c
 	} cmdbuf;
+	/** @target: relocate target information */
 	struct {
```

These additions are correct. The `struct drm_tegra_reloc` has kernel-doc (`=
/** ... */`) on the struct itself, and the nested anonymous struct members =
`cmdbuf.handle`, `cmdbuf.offset`, etc. are all documented, but the top-leve=
l `cmdbuf` and `target` aggregate members themselves were not. kernel-doc r=
equires all direct struct members to be documented, so adding these one-lin=
e descriptions fixes the warnings.

Minor nit: the descriptions are somewhat terse ("cmd information", "relocat=
e target information") =E2=80=94 they could be slightly more descriptive (e=
.g., "command buffer reference" and "relocation target reference"), but thi=
s is a very minor style preference and not a blocker. The existing sub-memb=
er docs already provide the detail.

**Fix 3=E2=80=936: Demote `/**` to `/*` on `#define` comments**

```c
-/**
+/*
  * Specify that bit 39 of the patched-in address should be set to switch
```

```c
-/**
+/*
  * Execute `words` words of Host1x opcodes specified in the `gather_data_p=
tr`
```

```c
-/**
+/*
  * Wait for a syncpoint to reach a value before continuing with further
  * commands.
```

```c
-/**
+/*
  * Wait for a syncpoint to reach a value before continuing with further
  * commands. The threshold is calculated relative to the start of the job.
```

All four are correct. `/**` signals kernel-doc format, which requires speci=
fic structured syntax (e.g., `@param:` descriptions for function parameters=
, or `DOC:` sections). These are free-form comments on `#define` macros, so=
 `/*` is the appropriate style. The change silences the warnings without lo=
sing any documentation content.

**Reviewed-by: No issues found.** The patch is correct and ready to merge.

---
Generated by Claude Code Patch Reviewer