public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: add missing MODULE_DEVICE_ID definitions
Date: Tue, 03 Mar 2026 14:09:11 +1000	[thread overview]
Message-ID: <review-patch1-20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com> (raw)
In-Reply-To: <20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com>

Patch Review

**Correctness**: All five `MODULE_DEVICE_TABLE` additions reference the correct array names for their respective files. Each array is a `static const struct of_device_id[]` properly terminated with `{}`, as expected.

**Minor observation — generic table name in dsi.c**: The DSI driver uses the generic name `dt_match`:

```c
MODULE_DEVICE_TABLE(of, dt_match);
```

This stands out because `adreno/adreno_device.c` also has a `static const struct of_device_id dt_match[]` (without `MODULE_DEVICE_TABLE`). The `MODULE_DEVICE_TABLE` macro creates a global alias symbol `__mod_of__dt_match_device_table`. Currently this works fine since only `dsi.c` generates that alias. However, if a `MODULE_DEVICE_TABLE(of, dt_match)` were ever added to `adreno_device.c`, it would cause a duplicate symbol at link time. All the other tables use descriptive prefixed names (`msm_dp_dt_match`, `dsi_phy_dt_match`, `msm_hdmi_dt_match`, `msm_hdmi_phy_dt_match`), so `dt_match` is inconsistent. This is a pre-existing naming issue though, not something introduced by this patch, so it's not a blocker.

**Fixes tag**: The tag references `060530f1ea67 ("drm/msm: use componentised device support")`, which introduced the component-based driver model requiring module autoloading for sub-devices. The author's note explains the v2 dropped the GPU chunk (presumably already in `msm-fixes`). The commit message still says "only MDSS (subsystem), KMS devices and GPU have corresponding MODULE_DEVICE_ID tables" — this is slightly misleading post-rebase since the GPU `MODULE_DEVICE_TABLE` doesn't appear to be present in the tree. A minor commit message clarity issue, not a code concern.

**No other issues found.** The placement of each `MODULE_DEVICE_TABLE` immediately after its corresponding match table's closing brace is consistent with kernel conventions.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-03  4:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28 17:20 [PATCH v2] drm/msm: add missing MODULE_DEVICE_ID definitions Dmitry Baryshkov
2026-03-03  4:09 ` Claude Code Review Bot [this message]
2026-03-03  4:09 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox