From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: add missing MODULE_DEVICE_ID definitions Date: Tue, 03 Mar 2026 14:09:11 +1000 Message-ID: In-Reply-To: <20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com> References: <20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com> <20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness**: All five `MODULE_DEVICE_TABLE` additions reference the cor= rect array names for their respective files. Each array is a `static const = struct of_device_id[]` properly terminated with `{}`, as expected. **Minor observation =E2=80=94 generic table name in dsi.c**: The DSI driver= uses the generic name `dt_match`: ```c MODULE_DEVICE_TABLE(of, dt_match); ``` This stands out because `adreno/adreno_device.c` also has a `static const s= truct of_device_id dt_match[]` (without `MODULE_DEVICE_TABLE`). The `MODULE= _DEVICE_TABLE` macro creates a global alias symbol `__mod_of__dt_match_devi= ce_table`. Currently this works fine since only `dsi.c` generates that alia= s. However, if a `MODULE_DEVICE_TABLE(of, dt_match)` were ever added to `ad= reno_device.c`, it would cause a duplicate symbol at link time. All the oth= er tables use descriptive prefixed names (`msm_dp_dt_match`, `dsi_phy_dt_ma= tch`, `msm_hdmi_dt_match`, `msm_hdmi_phy_dt_match`), so `dt_match` is incon= sistent. This is a pre-existing naming issue though, not something introduc= ed by this patch, so it's not a blocker. **Fixes tag**: The tag references `060530f1ea67 ("drm/msm: use componentise= d device support")`, which introduced the component-based driver model requ= iring module autoloading for sub-devices. The author's note explains the v2= dropped the GPU chunk (presumably already in `msm-fixes`). The commit mess= age still says "only MDSS (subsystem), KMS devices and GPU have correspondi= ng MODULE_DEVICE_ID tables" =E2=80=94 this is slightly misleading post-reba= se since the GPU `MODULE_DEVICE_TABLE` doesn't appear to be present in the = tree. A minor commit message clarity issue, not a code concern. **No other issues found.** The placement of each `MODULE_DEVICE_TABLE` imme= diately after its corresponding match table's closing brace is consistent w= ith kernel conventions. --- Generated by Claude Code Patch Reviewer