public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: amdgpu.h: fix all kernel-doc warnings
Date: Tue, 03 Mar 2026 14:34:13 +1000	[thread overview]
Message-ID: <review-patch1-20260228071856.2664080-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260228071856.2664080-1-rdunlap@infradead.org>

Patch Review

**Fix 1 — struct keyword:**

```
- * amdgpu_wb - This struct is used for small GPU memory allocation.
+ * struct amdgpu_wb - This struct is used for small GPU memory allocation.
```

Correct. The kernel-doc parser requires `struct amdgpu_wb` to associate the comment with the struct definition that follows. Without it, kernel-doc cannot understand the prototype, producing the warning at line 477.

**Fix 2 — enum value names:**

The old doc used short names like `@AMD_RESET_LEGACY`, `@AMD_RESET_MODE0`, etc., but the actual enum values in the tree are `AMD_RESET_METHOD_LEGACY`, `AMD_RESET_METHOD_MODE0`, etc. The patch updates all doc entries to match:

```
- * @AMD_RESET_LEGACY: Method reserved for SI, CIK and VI ASICs.
+ * @AMD_RESET_METHOD_LEGACY: Method reserved for SI, CIK and VI ASICs.
```

(and similarly for MODE0, MODE1, MODE2, LINK, BACO, PCI)

This is correct — I verified against the current tree (`amdgpu.h` lines 567–577) that all enum values use the `AMD_RESET_METHOD_` prefix.

**Fix 3 — new enum value documentation:**

```
+ * @AMD_RESET_METHOD_ON_INIT: Does a device reset during the driver init
+ *			  sequence.
```

The enum value `AMD_RESET_METHOD_ON_INIT` exists at line 576 in the tree but was previously undocumented. Adding this entry eliminates the corresponding kernel-doc warning.

**Minor nit (non-blocking):** The alignment of the continuation line for `AMD_RESET_METHOD_ON_INIT` uses tabs aligning to column ~27, while `AMD_RESET_METHOD_PCI` above it aligns its continuation slightly differently (columns 26 vs 27). This is cosmetic and within acceptable variation for kernel-doc comments.

**Another pre-existing nit (non-blocking):** The description for `AMD_RESET_METHOD_MODE0` still contains the phrasing "Not currently available for the any device" — the word "the" is superfluous ("for any device" would be correct). This existed before the patch and is not introduced by it, but the author could fix it while touching these lines.

**Verdict:** The patch is correct and complete. All kernel-doc warnings listed in the commit message are addressed. No functional code is changed.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03  4:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28  7:18 [PATCH] drm/amdgpu: amdgpu.h: fix all kernel-doc warnings Randy Dunlap
2026-03-02 10:26 ` Christian König
2026-03-03  4:34 ` Claude Code Review Bot [this message]
2026-03-03  4:34 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260228071856.2664080-1-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox