From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: amdgpu.h: fix all kernel-doc warnings Date: Tue, 03 Mar 2026 14:34:13 +1000 Message-ID: In-Reply-To: <20260228071856.2664080-1-rdunlap@infradead.org> References: <20260228071856.2664080-1-rdunlap@infradead.org> <20260228071856.2664080-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Fix 1 =E2=80=94 struct keyword:** ``` - * amdgpu_wb - This struct is used for small GPU memory allocation. + * struct amdgpu_wb - This struct is used for small GPU memory allocation. ``` Correct. The kernel-doc parser requires `struct amdgpu_wb` to associate the= comment with the struct definition that follows. Without it, kernel-doc ca= nnot understand the prototype, producing the warning at line 477. **Fix 2 =E2=80=94 enum value names:** The old doc used short names like `@AMD_RESET_LEGACY`, `@AMD_RESET_MODE0`, = etc., but the actual enum values in the tree are `AMD_RESET_METHOD_LEGACY`,= `AMD_RESET_METHOD_MODE0`, etc. The patch updates all doc entries to match: ``` - * @AMD_RESET_LEGACY: Method reserved for SI, CIK and VI ASICs. + * @AMD_RESET_METHOD_LEGACY: Method reserved for SI, CIK and VI ASICs. ``` (and similarly for MODE0, MODE1, MODE2, LINK, BACO, PCI) This is correct =E2=80=94 I verified against the current tree (`amdgpu.h` l= ines 567=E2=80=93577) that all enum values use the `AMD_RESET_METHOD_` pref= ix. **Fix 3 =E2=80=94 new enum value documentation:** ``` + * @AMD_RESET_METHOD_ON_INIT: Does a device reset during the driver init + * sequence. ``` The enum value `AMD_RESET_METHOD_ON_INIT` exists at line 576 in the tree bu= t was previously undocumented. Adding this entry eliminates the correspondi= ng kernel-doc warning. **Minor nit (non-blocking):** The alignment of the continuation line for `A= MD_RESET_METHOD_ON_INIT` uses tabs aligning to column ~27, while `AMD_RESET= _METHOD_PCI` above it aligns its continuation slightly differently (columns= 26 vs 27). This is cosmetic and within acceptable variation for kernel-doc= comments. **Another pre-existing nit (non-blocking):** The description for `AMD_RESET= _METHOD_MODE0` still contains the phrasing "Not currently available for the= any device" =E2=80=94 the word "the" is superfluous ("for any device" woul= d be correct). This existed before the patch and is not introduced by it, b= ut the author could fix it while touching these lines. **Verdict:** The patch is correct and complete. All kernel-doc warnings lis= ted in the commit message are addressed. No functional code is changed. --- Generated by Claude Code Patch Reviewer