Claude review: i915: Fix NULL pointer dereference in intel_dmc_update_dc6_allowed_count()

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Correctness: The fix is correct.** The NULL guard before the dereference is the right approach, and early-returning when `dmc` is NULL is the correct behavior — if DMC firmware isn't loaded, there's no DC6 tracking state to update.

```c
-	if (DISPLAY_VER(dmc->display) < 14)
+	if (!dmc || DISPLAY_VER(dmc->display) < 14)
```

**Minor suggestions:**

1. **Missing `Fixes:` tag.** A crash fix like this should include a `Fixes:` tag pointing to the commit that introduced `intel_dmc_update_dc6_allowed_count()`. This helps backport tracking.

2. **Missing `Cc: stable@vger.kernel.org`.** Since this is a NULL dereference panic that prevents kdump from generating vmcores, it's a candidate for stable backports.

3. **Style consideration:** The version check uses `dmc->display` when the function already receives `display` as a parameter (and `dmc->display` is the same pointer — set during `intel_dmc_init()`). The function could use `display` directly for the version check and keep the `dmc` NULL check separate for clarity:

   ```c
   if (!dmc || DISPLAY_VER(display) < 14)
       return;
   ```

   This makes the two conditions logically distinct: "is DMC available?" vs. "is the display version new enough?" — and avoids dereferencing `dmc` unnecessarily for the version check. However, this is a minor style point and the patch as-is is functionally correct.

4. **Broader observation:** The subagent research found several other functions in `intel_dmc.c` that also dereference `dmc` without a NULL check (e.g., `dmc_load_mmio()`, `dmc_load_program()`, `dmc_configure_event()`). Those are likely safe because they're only called from firmware-loading paths where `dmc` is known non-NULL, but the inconsistency in NULL-checking patterns across the file is worth noting for future hardening.

**Overall: The patch is a valid and minimal crash fix. Recommend adding `Fixes:` and `Cc: stable` tags.**

---
Generated by Claude Code Patch Reviewer