From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Import AMD_PMF namespace
Date: Tue, 03 Mar 2026 14:05:57 +1000 [thread overview]
Message-ID: <review-patch1-20260301005028.367618-1-superm1@kernel.org> (raw)
In-Reply-To: <20260301005028.367618-1-superm1@kernel.org>
Patch Review
**Correctness of the change itself:** The `MODULE_IMPORT_NS("AMD_PMF")` line is syntactically correct and placed in the right file alongside the other `MODULE_*` macros. The target symbol `amd_pmf_get_npu_data()` does exist and is exported in the `AMD_PMF` namespace:
```c
// drivers/platform/x86/amd/pmf/core.c:390
EXPORT_SYMBOL_NS_GPL(amd_pmf_get_npu_data, "AMD_PMF");
```
**Ordering nit:** The new line is inserted between `MODULE_LICENSE` and `MODULE_AUTHOR`:
```c
MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS("AMD_PMF");
MODULE_AUTHOR("XRT Team <runtimeca39d@amd.com>");
```
The conventional ordering groups `MODULE_IMPORT_NS` either at the very end (after `MODULE_DESCRIPTION`) or before `MODULE_LICENSE`. Placing it between `LICENSE` and `AUTHOR` is unconventional but not a hard rule violation.
**Missing dependency / no current user:** As noted above, there is currently no call to `amd_pmf_get_npu_data()` or any `amd_pmf` API anywhere in `drivers/accel/amdxdna/`. The commit message says "The amdxdna driver uses amd_pmf_get_npu_data()" but this is not true on the current tree. The commit message should clarify that this is a prerequisite for another patch or series that adds the actual usage.
**Suggestion:** If this patch is meant to land alongside or after another series that introduces the call, the commit message should reference that dependency (e.g., "This is needed for the upcoming NPU power management integration" or include a `Depends-on:` tag). If the consuming code has already landed on a different branch, a `Fixes:` tag referencing the commit that introduced the call would be appropriate to explain the build breakage this resolves.
**Verdict:** Straightforward namespace import. No functional concerns with the change itself, but the commit message needs to explain the dependency on the patch that actually calls `amd_pmf_get_npu_data()`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 0:50 [PATCH] accel/amdxdna: Import AMD_PMF namespace Mario Limonciello (AMD)
2026-03-02 18:00 ` Lizhi Hou
2026-03-03 4:05 ` Claude Code Review Bot [this message]
2026-03-03 4:05 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260301005028.367618-1-superm1@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox