From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Import AMD_PMF namespace Date: Tue, 03 Mar 2026 14:05:57 +1000 Message-ID: In-Reply-To: <20260301005028.367618-1-superm1@kernel.org> References: <20260301005028.367618-1-superm1@kernel.org> <20260301005028.367618-1-superm1@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness of the change itself:** The `MODULE_IMPORT_NS("AMD_PMF")` line is syntactically correct and placed in the right file alongside the other `MODULE_*` macros. The target symbol `amd_pmf_get_npu_data()` does exist and is exported in the `AMD_PMF` namespace: ```c // drivers/platform/x86/amd/pmf/core.c:390 EXPORT_SYMBOL_NS_GPL(amd_pmf_get_npu_data, "AMD_PMF"); ``` **Ordering nit:** The new line is inserted between `MODULE_LICENSE` and `MODULE_AUTHOR`: ```c MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("AMD_PMF"); MODULE_AUTHOR("XRT Team "); ``` The conventional ordering groups `MODULE_IMPORT_NS` either at the very end (after `MODULE_DESCRIPTION`) or before `MODULE_LICENSE`. Placing it between `LICENSE` and `AUTHOR` is unconventional but not a hard rule violation. **Missing dependency / no current user:** As noted above, there is currently no call to `amd_pmf_get_npu_data()` or any `amd_pmf` API anywhere in `drivers/accel/amdxdna/`. The commit message says "The amdxdna driver uses amd_pmf_get_npu_data()" but this is not true on the current tree. The commit message should clarify that this is a prerequisite for another patch or series that adds the actual usage. **Suggestion:** If this patch is meant to land alongside or after another series that introduces the call, the commit message should reference that dependency (e.g., "This is needed for the upcoming NPU power management integration" or include a `Depends-on:` tag). If the consuming code has already landed on a different branch, a `Fixes:` tag referencing the commit that introduced the call would be appropriate to explain the build breakage this resolves. **Verdict:** Straightforward namespace import. No functional concerns with the change itself, but the commit message needs to explain the dependency on the patch that actually calls `amd_pmf_get_npu_data()`. --- Generated by Claude Code Patch Reviewer