public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ethosu propagate devm_drm_dev_alloc() error code
Date: Tue, 03 Mar 2026 14:00:36 +1000	[thread overview]
Message-ID: <review-patch1-20260301090411.171060-1-alok.a.tiwari@oracle.com> (raw)
In-Reply-To: <20260301090411.171060-1-alok.a.tiwari@oracle.com>

Patch Review

**Correctness: Good.**

The change from:
```c
if (IS_ERR(ethosudev))
    return -ENOMEM;
```
to:
```c
if (IS_ERR(ethosudev))
    return PTR_ERR(ethosudev);
```

is correct. `devm_drm_dev_alloc()` is a wrapper around `__devm_drm_dev_alloc()` which can fail for multiple reasons, so hardcoding `-ENOMEM` loses information. `PTR_ERR()` is the standard pattern for extracting the error code from an `ERR_PTR` value.

**Minor nits:**

- The added blank line between `return PTR_ERR(ethosudev);` and `platform_set_drvdata(...)` is fine stylistically but is a whitespace-only change beyond the fix itself. Not a problem.

- The subject line is missing a colon after the subsystem prefix — it reads `accel/ethosu propagate` rather than `accel/ethosu: propagate`. This doesn't affect the code but is a minor deviation from standard kernel commit message conventions.

**Verdict:** Reviewed-by worthy. A straightforward and correct fix.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-03  4:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01  9:03 [PATCH] accel/ethosu propagate devm_drm_dev_alloc() error code Alok Tiwari
2026-03-03  4:00 ` Claude review: " Claude Code Review Bot
2026-03-03  4:00 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260301090411.171060-1-alok.a.tiwari@oracle.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox