From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ethosu propagate devm_drm_dev_alloc() error code
Date: Tue, 03 Mar 2026 14:00:36 +1000
Message-ID: <review-patch1-20260301090411.171060-1-alok.a.tiwari@oracle.com>
In-Reply-To: <20260301090411.171060-1-alok.a.tiwari@oracle.com>
References: <20260301090411.171060-1-alok.a.tiwari@oracle.com> <20260301090411.171060-1-alok.a.tiwari@oracle.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Correctness: Good.**

The change from:
```c
if (IS_ERR(ethosudev))
    return -ENOMEM;
```
to:
```c
if (IS_ERR(ethosudev))
    return PTR_ERR(ethosudev);
```

is correct. `devm_drm_dev_alloc()` is a wrapper around `__devm_drm_dev_allo=
c()` which can fail for multiple reasons, so hardcoding `-ENOMEM` loses inf=
ormation. `PTR_ERR()` is the standard pattern for extracting the error code=
 from an `ERR_PTR` value.

**Minor nits:**

- The added blank line between `return PTR_ERR(ethosudev);` and `platform_s=
et_drvdata(...)` is fine stylistically but is a whitespace-only change beyo=
nd the fix itself. Not a problem.

- The subject line is missing a colon after the subsystem prefix =E2=80=94 =
it reads `accel/ethosu propagate` rather than `accel/ethosu: propagate`. Th=
is doesn't affect the code but is a minor deviation from standard kernel co=
mmit message conventions.

**Verdict:** Reviewed-by worthy. A straightforward and correct fix.

---
Generated by Claude Code Patch Reviewer