From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then:
Date: Tue, 03 Mar 2026 13:51:52 +1000 [thread overview]
Message-ID: <review-patch1-20260301142033.88851-2-krzysztof.kozlowski@oss.qualcomm.com> (raw)
In-Reply-To: <20260301142033.88851-2-krzysztof.kozlowski@oss.qualcomm.com>
Patch Review
**Correctness: OK**
The top-level schema already defines `reg-names` at lines 59–64 of `gpu.yaml`:
```yaml
reg-names:
minItems: 1
items:
- const: kgsl_3d0_reg_memory
- const: cx_mem
- const: cx_dbgc
```
The removed block (inside the A6xx GMU `then:` clause, lines 443–448) is character-for-character identical:
```yaml
reg-names:
minItems: 1
items:
- const: kgsl_3d0_reg_memory
- const: cx_mem
- const: cx_dbgc
```
Since JSON Schema `allOf` creates an intersection of constraints, restating the same constraint in a `then:` block is a no-op. Removing it is the right thing to do.
**Contrast with the adreno-612.0 block (lines 400–408):** That `if:then:` also has a `reg-names` block, but it is *not* redundant — it works together with its sibling `reg: minItems: 3, maxItems: 3` to enforce that all three register regions must be present for that specific SoC. The top-level only requires `minItems: 1`, so the 612.0 override is meaningful and correctly left in place.
**Minor note:** The commit message says "Top-level reg-names defines already proper order for 'reg-names' with minItems: 1" — this is accurate, since the top-level `items` array already constrains the names and their ordering.
**No issues found.**
Reviewed-by is warranted.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-03 3:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 14:20 [PATCH v2] dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then: Krzysztof Kozlowski
2026-03-01 14:28 ` David Heidelberg
2026-03-01 16:18 ` Dmitry Baryshkov
2026-03-03 3:51 ` Claude review: " Claude Code Review Bot
2026-03-03 3:51 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260301142033.88851-2-krzysztof.kozlowski@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox