public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: msm: Fix reg ranges and clocks on Glymur
Date: Tue, 03 Mar 2026 13:37:09 +1000	[thread overview]
Message-ID: <review-patch1-20260302-glymur-fix-dp-bindings-reg-clocks-v3-1-8fe49ac1f556@oss.qualcomm.com> (raw)
In-Reply-To: <20260302-glymur-fix-dp-bindings-reg-clocks-v3-1-8fe49ac1f556@oss.qualcomm.com>

Patch Review

**Typo: `clocks-names` should be `clock-names`**

The new conditional block adds:

```yaml
        clocks-names:
          minItems: 5
          maxItems: 6
```

The top-level property is defined as `clock-names` (line 101 of dp-controller.yaml), not `clocks-names`. Because this references a non-existent property, this constraint is silently ignored and has no effect.

To be fair, this is a **pre-existing bug** — all four existing `allOf` blocks in this file (lines 245, 267, 289, 309) have the same `clocks-names` typo. The patch is just following the existing (broken) pattern. Nevertheless, it would be good to fix it here or as a separate preparatory cleanup. As-is, none of the `clock-names` constraints in the entire file actually do anything.

**Commit message description inconsistency**

The commit message states:
> "the first three only have two streams wired up physically to the display subsystem, while the fourth controller has only one stream (SST)"

But then says:
> "allowing either one pixel clock, for the **third** DP controller, or two pixel clocks, for the rest of them"

These contradict each other. The first paragraph says the **fourth** controller is SST (one stream/one pixel clock), but the second says the **third** controller has one pixel clock. The description of which controller is SST-only should be clarified.

**Code change itself looks correct.** Removing `qcom,glymur-dp` from the 5-reg-entry group and adding a dedicated block requiring 9 reg entries and 5-6 clocks is the right approach to match the hardware description (4 ports + 2 MST link blocks = 9 reg ranges).

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03  3:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02  9:58 [PATCH v3 0/2] dt-bindings: display: msm: Fix Glymur DP controller reg ranges and clock Abel Vesa
2026-03-02  9:58 ` [PATCH v3 1/2] dt-bindings: display: msm: Fix reg ranges and clocks on Glymur Abel Vesa
2026-03-02 11:36   ` Rob Herring (Arm)
2026-03-03  3:37   ` Claude Code Review Bot [this message]
2026-03-02  9:58 ` [PATCH v3 2/2] dt-bindings: display: msm: Fix reg ranges for DP example node Abel Vesa
2026-03-02 13:15   ` Dmitry Baryshkov
2026-03-03  3:37   ` Claude review: " Claude Code Review Bot
2026-03-03  3:37 ` Claude review: dt-bindings: display: msm: Fix Glymur DP controller reg ranges and clock Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-03  9:03 [PATCH v4] dt-bindings: display: msm: Fix reg ranges and clocks on Glymur Abel Vesa
2026-03-03 21:43 ` Claude review: " Claude Code Review Bot
2026-03-03 21:43 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260302-glymur-fix-dp-bindings-reg-clocks-v3-1-8fe49ac1f556@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox