From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vfs: introduce kino_t typedef and PRIino format macro Date: Wed, 04 Mar 2026 08:15:02 +1000 Message-ID: In-Reply-To: <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean introduction of the scaffolding. The placement after `struct inode_state_flags` and before `struct inode` is appropriate. ```c typedef unsigned long kino_t; #define PRIino "l" ``` The `PRIino` naming follows the userspace `PRIu64`/`PRIx64` convention from ``, which is a reasonable model. However, the macro provides only the length modifier (not a complete specifier), so usage is `"%" PRIino "u"` -- this is somewhat unusual in kernel code and creates moderately ugly format strings. The commit message documents this clearly, which is good. The change of `i_ino` from `unsigned long` to `kino_t` is a no-op at this point since `kino_t` is `unsigned long`. **No issues.** --- Generated by Claude Code Patch Reviewer