public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/mdp5: Remove MSM8974v1
Date: Tue, 03 Mar 2026 13:20:38 +1000	[thread overview]
Message-ID: <review-patch1-20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com> (raw)
In-Reply-To: <20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com>

Patch Review

**Correctness**: The patch correctly removes the `msm8x74v1_config` definition (92 lines of dead config) and its handler table entry `{ .revision = 0, ... }`. The rename from `msm8x74v2_config` to `msm8x74_config` is consistent — the `.name` field was already `"msm8x74"` (without any version suffix), so the C symbol now matches the reported name.

The lookup logic in `mdp5_cfg_init()` iterates `cfg_handlers_v1[]` matching on `minor` revision number. With the revision 0 entry removed, any v1 hardware attempting to probe would fail with the existing `"unexpected MDP minor revision"` error at line 1163, which is the correct behavior for unsupported hardware.

**Minor issue — duplicate `Signed-off-by` tag**: The commit message has `Signed-off-by: Konrad Dybcio` appearing twice — once before the `---` separator and once after it (lines 91 and 94 of the mbox). The one after `---` won't be included in the final commit by git-am, but the duplication looks accidental — possibly a b4 artifact.

```
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
related: https://lore.kernel.org/...
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
```

**No functional concerns**: The remaining revision 2 entry (`msm8x74_config`) is untouched in content, only renamed. No other file references `msm8x74v1_config` or `msm8x74v2_config` by name (they are only used via the handler table), so no other files need updating.

Overall: This is a clean removal patch. The rationale is sound (v1 silicon never shipped commercially), and the implementation is correct. The only nit is the duplicate Signed-off-by.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03  3:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 13:41 [PATCH] drm/msm/mdp5: Remove MSM8974v1 Konrad Dybcio
2026-03-02 13:57 ` Dmitry Baryshkov
2026-03-03  3:20 ` Claude Code Review Bot [this message]
2026-03-03  3:20 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox