From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/mdp5: Remove MSM8974v1 Date: Tue, 03 Mar 2026 13:20:38 +1000 Message-ID: In-Reply-To: <20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com> References: <20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com> <20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness**: The patch correctly removes the `msm8x74v1_config` definit= ion (92 lines of dead config) and its handler table entry `{ .revision =3D = 0, ... }`. The rename from `msm8x74v2_config` to `msm8x74_config` is consis= tent =E2=80=94 the `.name` field was already `"msm8x74"` (without any versi= on suffix), so the C symbol now matches the reported name. The lookup logic in `mdp5_cfg_init()` iterates `cfg_handlers_v1[]` matching= on `minor` revision number. With the revision 0 entry removed, any v1 hard= ware attempting to probe would fail with the existing `"unexpected MDP mino= r revision"` error at line 1163, which is the correct behavior for unsuppor= ted hardware. **Minor issue =E2=80=94 duplicate `Signed-off-by` tag**: The commit message= has `Signed-off-by: Konrad Dybcio` appearing twice =E2=80=94 once before t= he `---` separator and once after it (lines 91 and 94 of the mbox). The one= after `---` won't be included in the final commit by git-am, but the dupli= cation looks accidental =E2=80=94 possibly a b4 artifact. ``` Signed-off-by: Konrad Dybcio --- related: https://lore.kernel.org/... Signed-off-by: Konrad Dybcio --- ``` **No functional concerns**: The remaining revision 2 entry (`msm8x74_config= `) is untouched in content, only renamed. No other file references `msm8x74= v1_config` or `msm8x74v2_config` by name (they are only used via the handle= r table), so no other files need updating. Overall: This is a clean removal patch. The rationale is sound (v1 silicon = never shipped commercially), and the implementation is correct. The only ni= t is the duplicate Signed-off-by. --- Generated by Claude Code Patch Reviewer