public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example
Date: Tue, 03 Mar 2026 13:09:09 +1000	[thread overview]
Message-ID: <review-patch1-20260302-v6-18-topic-imx93-parallel-display-v10-1-634fe2778c7a@pengutronix.de> (raw)
In-Reply-To: <20260302-v6-18-topic-imx93-parallel-display-v10-1-634fe2778c7a@pengutronix.de>

Patch Review

**Subject:** `[PATCH v10 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example`

This patch adds the `dpi-bridge` subnode binding to the existing `fsl,imx93-media-blk-ctrl.yaml`. Looks reasonable.

**Minor observations:**

1. The binding only lists `nxp,imx91-pdfc` and `nxp,imx93-pdfc` in the compatible enum, but the driver in patch 2 only has a match for `nxp,imx93-pdfc`. If `nxp,imx91-pdfc` is a distinct compatible in the binding, the driver should also match it (or document a fallback). See patch 2 comments.

2. The `bus-width` enum is well-documented:
```yaml
                  bus-width:
                    enum: [ 16, 18, 24 ]
```
But the driver only acts on `bus-width == 18` (truncating LSBs). A `bus-width` of 16 at the physical level isn't handled differently in the driver. This is okay if `bus-width: 16` is only informational, but worth confirming intent.

3. No issues with the example node addition - it properly demonstrates `bus-width = <18>` in the output endpoint.

**Verdict:** Looks good. Already has Rob's Reviewed-by.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-03  3:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 16:10 [PATCH v10 0/3] Add i.MX91/93 parallel display support Marco Felsch
2026-03-02 16:10 ` [PATCH v10 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example Marco Felsch
2026-03-03  3:09   ` Claude Code Review Bot [this message]
2026-03-02 16:10 ` [PATCH v10 2/3] drm/bridge: imx: Add i.MX93 parallel display format configuration support Marco Felsch
2026-03-03  3:09   ` Claude review: " Claude Code Review Bot
2026-03-02 16:10 ` [PATCH v10 3/3] arm64: dts: imx93: Add parallel display output nodes Marco Felsch
2026-03-03  3:09   ` Claude review: " Claude Code Review Bot
2026-03-03  3:04 ` [PATCH v10 0/3] Add i.MX91/93 parallel display support Liu Ying
2026-03-03  3:09 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-03 10:34 [PATCH v11 0/3] " Marco Felsch
2026-03-03 10:34 ` [PATCH v11 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example Marco Felsch
2026-03-03 21:36   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260302-v6-18-topic-imx93-parallel-display-v10-1-634fe2778c7a@pengutronix.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox