From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example Date: Tue, 03 Mar 2026 13:09:09 +1000 Message-ID: In-Reply-To: <20260302-v6-18-topic-imx93-parallel-display-v10-1-634fe2778c7a@pengutronix.de> References: <20260302-v6-18-topic-imx93-parallel-display-v10-0-634fe2778c7a@pengutronix.de> <20260302-v6-18-topic-imx93-parallel-display-v10-1-634fe2778c7a@pengutronix.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Subject:** `[PATCH v10 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example` This patch adds the `dpi-bridge` subnode binding to the existing `fsl,imx93-media-blk-ctrl.yaml`. Looks reasonable. **Minor observations:** 1. The binding only lists `nxp,imx91-pdfc` and `nxp,imx93-pdfc` in the compatible enum, but the driver in patch 2 only has a match for `nxp,imx93-pdfc`. If `nxp,imx91-pdfc` is a distinct compatible in the binding, the driver should also match it (or document a fallback). See patch 2 comments. 2. The `bus-width` enum is well-documented: ```yaml bus-width: enum: [ 16, 18, 24 ] ``` But the driver only acts on `bus-width == 18` (truncating LSBs). A `bus-width` of 16 at the physical level isn't handled differently in the driver. This is okay if `bus-width: 16` is only informational, but worth confirming intent. 3. No issues with the example node addition - it properly demonstrates `bus-width = <18>` in the output endpoint. **Verdict:** Looks good. Already has Rob's Reviewed-by. --- --- Generated by Claude Code Patch Reviewer