From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: select DRM abstractions in Kconfig Date: Tue, 03 Mar 2026 12:48:18 +1000 Message-ID: In-Reply-To: <20260302232500.244489-2-deborah.brouwer@collabora.com> References: <20260302232500.244489-1-deborah.brouwer@collabora.com> <20260302232500.244489-2-deborah.brouwer@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Author:** Boris Brezillon Introduces `DRM_TYR_STATIC_DEPS` to ensure `DRM_GEM_SHMEM_HELPER` and `DRM_= GPUVM` are built-in even when Tyr is `=3Dm`. Also adds `MMU`, `IOMMU_SUPPOR= T`, and `IOMMU_IO_PGTABLE_LPAE` dependencies. The ordering of `depends` and `select` is slightly unusual =E2=80=94 conven= tionally all `depends on` lines come before `select` lines: ``` + depends on MMU + select DRM_TYR_STATIC_DEPS + select IOMMU_IO_PGTABLE_LPAE + depends on IOMMU_SUPPORT ``` Having `depends on IOMMU_SUPPORT` after the `select` lines is a style nit = =E2=80=94 it works correctly, but grouping all `depends` together improves = readability. Not a blocker. The fix for `if` -> `If` capitalization is a nice bonus cleanup. No functional issues. --- Generated by Claude Code Patch Reviewer