public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: dma-heap: Keep track of the heap device struct
Date: Wed, 04 Mar 2026 07:19:20 +1000	[thread overview]
Message-ID: <review-patch1-20260303-b4-dmabuf-heap-coherent-rmem-v2-1-65a4653b3378@redhat.com> (raw)
In-Reply-To: <20260303-b4-dmabuf-heap-coherent-rmem-v2-1-65a4653b3378@redhat.com>

Patch Review

**From John Stultz, carried by Albert Esteve.**

This patch stores the `device *` returned by `device_create()` in `heap->heap_dev` instead of a local variable, and adds a `dma_heap_get_dev()` accessor.

**Issues:**

1. **Spurious `get_device()` and extra blank line.** The patch adds:
```c
+	/* Make sure it doesn't disappear on us */
+	heap->heap_dev = get_device(heap->heap_dev);
+
+
	/* Add heap to the list */
```
There's a double blank line here (minor style). More importantly, this `get_device()` takes an extra reference on a device that was just created by `device_create()` -- the heap already holds a reference from creation, and there is no corresponding `put_device()` in any error or teardown path in this patch. This leaks a refcount. Patch 2 restructures things and removes this `get_device()`, but in the meantime patch 1 is broken in isolation. Ideally each patch should be correct standalone (bisectability).

2. **The `heap_dev` pointer is not cleaned up on the `err3` path** (duplicate name). If `device_create()` succeeds but the name check fails, `heap_dev` is stored in the struct but `device_destroy()` cleans up by devt. The field is then freed with `kfree(heap)`. This is fine functionally, but the extra `get_device()` above means the device won't actually be freed. Again, this is resolved in patch 2, but patch 1 in isolation has a refcount leak.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03 21:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 12:33 [PATCH v2 0/6] dma-buf: heaps: add coherent reserved-memory heap Albert Esteve
2026-03-03 12:33 ` [PATCH v2 1/6] dma-buf: dma-heap: Keep track of the heap device struct Albert Esteve
2026-03-03 13:10   ` Maxime Ripard
2026-03-03 21:19   ` Claude Code Review Bot [this message]
2026-03-03 12:33 ` [PATCH v2 2/6] dma-buf: dma-heap: split dma_heap_add Albert Esteve
2026-03-03 21:19   ` Claude review: " Claude Code Review Bot
2026-03-03 12:33 ` [PATCH v2 3/6] of_reserved_mem: add a helper for rmem device_init op Albert Esteve
2026-03-03 13:13   ` Maxime Ripard
2026-03-03 21:19   ` Claude review: " Claude Code Review Bot
2026-03-03 12:33 ` [PATCH v2 4/6] dma-buf: heaps: Add Coherent heap to dmabuf heaps Albert Esteve
2026-03-03 13:20   ` Maxime Ripard
2026-03-03 14:47     ` Albert Esteve
2026-03-03 21:19   ` Claude review: " Claude Code Review Bot
2026-03-03 12:33 ` [PATCH v2 5/6] dma: coherent: register to coherent heap Albert Esteve
2026-03-03 21:19   ` Claude review: " Claude Code Review Bot
2026-03-03 12:33 ` [PATCH v2 6/6] dma-buf: heaps: coherent: Turn heap into a module Albert Esteve
2026-03-03 21:19   ` Claude review: " Claude Code Review Bot
2026-03-03 20:55 ` [PATCH v2 0/6] dma-buf: heaps: add coherent reserved-memory heap John Stultz
2026-03-03 21:19 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-06 10:36 [PATCH v3 0/6] " Albert Esteve
2026-03-06 10:36 ` [PATCH v3 1/6] dma-buf: dma-heap: Keep track of the heap device struct Albert Esteve
2026-03-08 23:02   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260303-b4-dmabuf-heap-coherent-rmem-v2-1-65a4653b3378@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox