public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions
Date: Wed, 04 Mar 2026 08:32:57 +1000	[thread overview]
Message-ID: <review-patch1-20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com> (raw)
In-Reply-To: <20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com>

Patch Review

**Correctness: Good.** The patch correctly identifies and resolves the duplicate definitions. Before the patch, the file had:

1. Lines 112-117 (guarded):
```asm
#if RELAXED_SCHEDULING_IN_TRAP
var TTMP11_SCHED_MODE_SHIFT   = 26
var TTMP11_SCHED_MODE_SIZE    = 2
var TTMP11_SCHED_MODE_MASK    = 0xC000000
#endif
```

2. Lines ~136-138 (unconditional):
```asm
var TTMP11_SCHED_MODE_SHIFT   = 26
var TTMP11_SCHED_MODE_SIZE    = 2
var TTMP11_SCHED_MODE_MASK    = 0xC000000
```

The patch removes the first block and wraps the second with the `#if RELAXED_SCHEDULING_IN_TRAP` / `#endif` guard. I verified that all usages of these three variables (at lines 241, 242, 329, 330, 1379 post-patch) are within `#if RELAXED_SCHEDULING_IN_TRAP` guards, confirming that making them conditional is safe and correct.

**Placement:** The surviving definitions are grouped with the other `TTMP11_*` variables (`TTMP11_DEBUG_TRAP_ENABLED_*`, `TTMP11_FIRST_REPLAY_*`, `TTMP11_REPLAY_W64H_*`, `TTMP11_FXPTR_*`), which is a sensible location.

**Minor observation:** The variables immediately following the `#endif` (e.g., `TTMP11_DEBUG_TRAP_ENABLED_SHIFT` at line 136) are not guarded by any conditional. This is fine — those are used unconditionally elsewhere and are not part of this patch's scope.

**Commit message:** Clear, concise, and accurate. The Fixes tag correctly identifies the commit that introduced the duplication. The Signed-off-by is present.

**Reviewed-by: No issues found.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 21:29 [PATCH RESEND] drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Peter Colberg
2026-03-03 22:32 ` Claude review: " Claude Code Review Bot
2026-03-03 22:32 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-24 17:21 [PATCH] " Peter Colberg
2026-02-27  4:54 ` Claude review: " Claude Code Review Bot
2026-02-27  4:54 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox