From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Date: Wed, 04 Mar 2026 08:32:57 +1000 Message-ID: In-Reply-To: <20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com> References: <20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com> <20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The patch correctly identifies and resolves the dupl= icate definitions. Before the patch, the file had: 1. Lines 112-117 (guarded): ```asm #if RELAXED_SCHEDULING_IN_TRAP var TTMP11_SCHED_MODE_SHIFT =3D 26 var TTMP11_SCHED_MODE_SIZE =3D 2 var TTMP11_SCHED_MODE_MASK =3D 0xC000000 #endif ``` 2. Lines ~136-138 (unconditional): ```asm var TTMP11_SCHED_MODE_SHIFT =3D 26 var TTMP11_SCHED_MODE_SIZE =3D 2 var TTMP11_SCHED_MODE_MASK =3D 0xC000000 ``` The patch removes the first block and wraps the second with the `#if RELAXE= D_SCHEDULING_IN_TRAP` / `#endif` guard. I verified that all usages of these= three variables (at lines 241, 242, 329, 330, 1379 post-patch) are within = `#if RELAXED_SCHEDULING_IN_TRAP` guards, confirming that making them condit= ional is safe and correct. **Placement:** The surviving definitions are grouped with the other `TTMP11= _*` variables (`TTMP11_DEBUG_TRAP_ENABLED_*`, `TTMP11_FIRST_REPLAY_*`, `TTM= P11_REPLAY_W64H_*`, `TTMP11_FXPTR_*`), which is a sensible location. **Minor observation:** The variables immediately following the `#endif` (e.= g., `TTMP11_DEBUG_TRAP_ENABLED_SHIFT` at line 136) are not guarded by any c= onditional. This is fine =E2=80=94 those are used unconditionally elsewhere= and are not part of this patch's scope. **Commit message:** Clear, concise, and accurate. The Fixes tag correctly i= dentifies the commit that introduced the duplication. The Signed-off-by is = present. **Reviewed-by: No issues found.** --- Generated by Claude Code Patch Reviewer